base: socket_send: return error upon short write

probably, short writes are due to client disconnect client is automatically kicked by the calling function

Signed-off-by: Andreas Fenkart andreas.fenkart@dev.digitalstrom.org

base/socket_send.c

@@ -127,9 +127,19 @@ int socket_sendv(int socket, struct iovec *iov, int iovcnt)
return -ret;
}
-        if (ret != total) {
-            /* http://redmine.digitalstrom.org/issues/9038 */
-            report(LOG_CRIT, "ret(%d) != total(%d)\n", ret, total);
+        if (ret < total) {
+            /*
+             * As described above, the kernel is accessing user space
+             * memory directly, iovec only declares its location. Hence it
+             * can split it into packets at will.
+             * The only reason left, to explain a short write, seems a
+             * client side issued disconnect in the middle of a
+             * transaction
+             * http://redmine.digitalstrom.org/issues/9038
+             */
+            report(LOG_NOTICE, "%s short write written(%d) < total(%d)\n",
+                   __func__, ret, total);
+            return -ECONNABORTED;
}
assert(ret == total);