An error occurred while retrieving approval data for this merge request.
4 unresolved threads
Activity
@kkwiatkowska This seems to be working for me, but do you see any potential
js
trap? :)620 620 newControl.ctrlYmin = Property.getProperty('controllerDefinitions/' + definitionID + '/ymin'); 621 621 newControl.ctrlYmax = Property.getProperty('controllerDefinitions/' + definitionID + '/ymax'); 622 622 newControl.ctrlAntiWindUp = ((Property.getProperty('controllerDefinitions/' + definitionID + '/antiwindup')!=0)?true:false); 623 newControl.emergencyValue = Property.getProperty('controllerConfig/' + zone.id + '/emergenyValue') || 75; 623 if (Property.getProperty('controllerConfig/' + zone.id + '/emergenyValue') == null || changed this line in version 2 of the diff
101 101 if ((Property.getNode('controllerConfig/' + zoneID)!=null) && 102 102 (Property.getNode('controllerConfig/' + zoneID + '/emergenyValue')!=null)) { 103 103 var emergencyValue=Property.getNode('controllerConfig/' + zoneID + '/emergenyValue').getValue(); 104 forceUpdateNeeded = !((emergencyValue > 0) && (emergencyValue <= 100)); 104 forceUpdateNeeded = !((emergencyValue >= 0) && (emergencyValue <= 100)); changed this line in version 2 of the diff
101 101 if ((Property.getNode('controllerConfig/' + zoneID)!=null) && 102 102 (Property.getNode('controllerConfig/' + zoneID + '/emergenyValue')!=null)) { 103 103 var emergencyValue=Property.getNode('controllerConfig/' + zoneID + '/emergenyValue').getValue(); 104 forceUpdateNeeded = !((emergencyValue > 0) && (emergencyValue <= 100)); 104 forceUpdateNeeded = !((emergencyValue >= 0) && (emergencyValue <= 100)); 105 105 } 106 106 if (forceUpdateNeeded == true) { changed this line in version 2 of the diff
added 1 commit
620 620 newControl.ctrlYmin = Property.getProperty('controllerDefinitions/' + definitionID + '/ymin'); 621 621 newControl.ctrlYmax = Property.getProperty('controllerDefinitions/' + definitionID + '/ymax'); 622 622 newControl.ctrlAntiWindUp = ((Property.getProperty('controllerDefinitions/' + definitionID + '/antiwindup')!=0)?true:false); 623 if (Property.getProperty('controllerConfig/' + zone.id + '/emergenyValue') == null || 624 Property.getProperty('controllerConfig/' + zone.id + '/emergenyValue') < 0 || 625 Property.getProperty('controllerConfig/' + zone.id + '/emergenyValue') > 100) { 623 var emergencyValue = Property.getProperty('controllerConfig/' + zone.id + '/emergenyValue'); 624 if (emergencyValue == null || emergencyValue < 0 || emergencyValue > 100) { 626 625 newControl.emergencyValue = 75; 627 626 } else { 628 627 newControl.emergencyValue = Property.getProperty('controllerConfig/' + zone.id + '/emergenyValue'); changed this line in version 3 of the diff
added 1 commit
mentioned in commit 326047d4