dsConnectorHttpServer: fail on unknown http method

src/ds-connector/http-server-test.cpp

@@ -103,6 +103,28 @@ SCENARIO("dsConnectorHttpServer", TAGS) {
         SUCCEED();
       }
     }
+
+    THEN("Unknown verb returns error") {
+      auto request = http::request<http::string_body>{};
+      request.version(11);
+      request.method_string("unknown");
+      request.target("/");
+      request.prepare_payload();
+      http::async_write(socket, request, [&](error_code ec, std::size_t) { loop.stop(); });
+      loop.run();
+
+      auto buffer = boost::beast::flat_buffer{};
+      auto response = http::response<http::string_body>{};
+      http::async_read(socket, buffer, response, [&](error_code ec, std::size_t) {
+        CHECK(response.version() == 11);
+        CHECK(response.result() == http::status{500});
+        CHECK(response[http::field::content_type] == "application/json");
+        CHECK(response.body().find("Unknown ::dsApi::HttpMethod enum option") != std::string::npos);
+        loop.stop();
+      });
+      loop.run();
+      SUCCEED();
+    }
   }
 }
 

src/ds-connector/http-server.cpp

@@ -70,7 +70,7 @@ private:
             self->m_router.asyncInvoke(
                 dsApi::HttpRequest{
                     .path = std::string{path},
-                    .httpArgs = {.method = ds::toEnum<dsApi::HttpMethod>(request->method_string()),
+                    .httpArgs = {.method = ds::requireEnum<dsApi::HttpMethod>(request->method_string()),
                                  .content = request->body().size() ? ds::fromJson<ds::JsonFragment>(request->body())
                                                                    : ds::JsonFragment{},
                                  .query = std::string{query},