Activity
- Resolved by Branislav Katreniak
- Resolved by Branislav Katreniak
- Resolved by Branislav Katreniak
- Resolved by Branislav Katreniak
- Resolved by Branislav Katreniak
- Resolved by Branislav Katreniak
- Resolved by Branislav Katreniak
- Resolved by Branislav Katreniak
- Resolved by Branislav Katreniak
- Resolved by Branislav Katreniak
- Resolved by Branislav Katreniak
- Resolved by Branislav Katreniak
added 78 commits
-
fedbe6a8...ccf4794f - 75 commits from branch
dss:master
- c2e38a13 - Added more product definitions
- a44a73f3 - Store vdc implementations IDs in apartment.xml
- e745f393 - Add rental reset feature
Toggle commit list-
fedbe6a8...ccf4794f - 75 commits from branch
Updated according to the outcome of the last meeting.
Edited by Jinassigned to @mtross
Build finished. Tests FAILED. Build results available at: http://dsjenkins.cloudapp.net/jenkins/job/dSS_MR/1692/
- Resolved by Branislav Katreniak
191 if (pPlugin != NULL) { 192 eventCollector.reset(new EventCollector(*pPlugin)); 193 eventCollector->subscribeTo(EventName::AddonsRentalResetComplete); 194 } else { 195 jsonMessage += "Could not subscribe to rental reset completion event from add-ons"; 196 } 197 198 boost::shared_ptr<Event> event = boost::make_shared<Event>(EventName::AddonsPerformRentalReset); 199 if (DSS::hasInstance()) { 200 DSS::getInstance()->raiseEvent(event); 201 } 202 203 if (pPlugin != NULL) { 204 // the addons will respond with at least one event which will indicate 205 // that we can break out and continue, but we have to wait for it 206 // and we agreed that we can trust that it will arrive All this particular code cares about is: add ons will send an event when all of them are done resetting. First event counts for all. Implementation and synchronization inside the add-ons is not part of this MR and will be done by Roman.
So you'll never see the "how" in this MR, because it happens elsewhere.
I was not involved in design discussions, ... but what about more distributed design?
- Introduce persistent token
rentalRevision
in dss (e.g. random string) - e.g. property. - Rental reset changes
rentalRevision
and restarts dss and all add-ons. - Add-ons interested in rental reset, at startup, compare current
rentalRevision
in dss with previous one. If it differs, they invoke rental reset cleanup.
This approach avoids explicit synchronization. And it will work for any component that is able to read
rentalRevision
and is able to detect dss restart with having explicit support for that component in rental reset core code.- Introduce persistent token
changed this line in version 7 of the diff
added 35 commits
-
e745f393...c558dcd5 - 32 commits from branch
dss:master
- 40ee587a - Added more product definitions
- 5d01572f - Store vdc implementations IDs in apartment.xml
- 1f9a1424 - Add rental reset feature
Toggle commit list-
e745f393...c558dcd5 - 32 commits from branch