An error occurred while retrieving approval data for this merge request.
1 unresolved thread
#20369
Activity
205 205 if (m_pPropertyNode == NULL && DSS::hasInstance()) { 206 206 if (DSS::getInstance()->getPropertySystem().getProperty(path) != NULL) { 207 207 // avoid publishing duplicate state information when reading out devices multiple times 208 // and re-use the existing state node 209 m_pPropertyNode = DSS::getInstance()->getPropertySystem().getProperty(path); 210 DS_PRINT("StateProperty already exists: " + path); changed this line in version 2 of the diff
-
In my mental model, code execution shall never get to the changed lines. If it gets there, I consider the game already lost. So I have hard time to reason whether this change is good or bad. I would expect assert there.
That said, I don't have objections to merge this change. If it really fixes the crashes we see, I am happy to move on. I don't have simple answers how to get out from this mess.
Edited by Branislav Katreniak added 1 commit
- 681b9c97 - model: do not leave m_pPropertyNode NULL when path already exists
mentioned in commit 64783951
