Bka - dSM could end up being "ready" but not "connected"

refs #20251

Continues !1009 (closed)

Relevant discussion from continued MR: !1009 (diffs)

mentioned in merge request !1009 (closed)

Build finished. Tests FAILED. Build results available at: http://dsjenkins.cloudapp.net/jenkins/job/dSS_MR/1714/

I looked quite a while to code related to isConnected and isPresent in DSMeter. But I have no clue what is the intended behavior difference. So I have hard time to distinguish bugs from unnecessary complexity and from features.

The big problem is that if we don't set setIsConnected(true), isPresent() returns false.

    bool isPresent() const { return m_IsPresent & m_IsConnected; }

That may lead to reported problem. Hard to follow, the bus scanner code is quite convoluted.

In any case, the changed code steps out of line from other similar code. ModelMaintenance::onJoinedDSMeter handling dsm announcement from dsm-api sets also setIsConnected.

    meter->setIsPresent(true);
    meter->setIsConnected(true);
```

mentioned in commit 49d5d77b

merged