Bka sessions (!1169) · Merge requests · dSS - digitalSTROM Server / dss-mainline · GitLab

Merged Branislav Katreniak requested to merge brano/dss-mainline:bka-sessions into master 6 years ago

Cleanup, fixes from investigation of situation where json requests were failing because dss was out of sessions.

10910490 webserver: automatically remove automatic sessions on trusted port
18a0f15a sessionManager: refactor mutex to recursive mutes
10fad176 webserver: remove dead argument in logDownloadHandler

https://trello.com/c/djII9OJX/134-stabilize-tests

Activity

Michal Tomaszewski @MichalTomaszewski started a thread on the diff 6 years ago

Last updated 6 years ago by Michal Tomaszewski

src/web/webserver.cpp

746	749	self.log("Session limit reached: " + request.getUrlPath(), lsError);
747	750	return 0;
748	751	}
	752	removeAutomaticSession = [&self, newToken] { self.m_SessionManager->removeSession(newToken); };
Michal Tomaszewski @MichalTomaszewski · 6 years ago Maintainer How is this supposed to work? It looks like removing session right after registering it. What is the big picture here? Branislav Katreniak @brano · 6 years ago Author Maintainer `removeAutomaticSession` is invoked at the end of the function. See `DS_DEFER` above. `removeAutomaticSession` does nothing normally. But if this code path is used, this lambda is assigned to it and called at the end of function. Michal Tomaszewski @MichalTomaszewski · 6 years ago Maintainer Ah, that's right. I confused DS_DEFER with something else. Forgot how it was supposed to work. Then it is +1. Please register or sign in to reply

Branislav Katreniak mentioned in commit 752bbad1 6 years ago

mentioned in commit 752bbad1
Branislav Katreniak merged 6 years ago

merged

Please register or sign in to reply