Signed-off-by: Andreas Fenkart andreas.fenkart@dev.digitalstrom.org
Activity
Design wise ... I have hard time to fit
supportedDimmingFunction
function into apartment api concepts.What is dimming? Do all (and only) shade and awnings devices support dimming?
This page documents all scenario calls as visible from apps over apartment api. https://confluence.digitalstrom.org/display/SA/Standard+Scenarios
Pls compare to these functions, not sure what the underlying guideline is...
bool HardwareAbstraction::deviceCacheable(const Dsuid& dsuid) const bool HardwareAbstraction::supportedBasicFunction(const Device& device) const
dimming is a shot in the air, but better then suportedFunctionSet2
assigned to @jeanvisagie
281 if (!supportedDimmingFunction(*device)) { 282 return false; // no change without implementation 281 283 } 282 return false;// no change without implementation 284 return getHalDevice(*device).setSceneLocalPrio(*device, sceneId); 283 285 } 284 286 285 287 bool HardwareAbstraction::callSceneMin(const Dsuid& dsuid, int sceneId, ds::DateTime now) const { 286 288 auto device = m_apartment->getDeviceByDSID(dsuid); 287 if (device->getDeviceClass() == DEVICE_CLASS_GE) { 288 return m_halLight.callSceneMin(*device, sceneId, now); 289 } else if (device->getDeviceClass() == DEVICE_CLASS_GR && device->hasExtendendSceneTable()) { 290 return m_halShade.callSceneMin(*device, sceneId, now); 291 } else if (device->getDeviceClass() == DEVICE_CLASS_SW && device->hasOutput()) { 292 return m_halJoker.callSceneMin(*device, sceneId, now); 289 if (!supportedDimmingFunction(*device)) { mentioned in commit daadf0ca