Removes not needed locking inside SQLite3 class. The SQLite3 class is simply not reentrant like nearly all c++ classes.
Activity
Build Started: http://dsjenkins.cloudapp.net/jenkins/job/dSS_MR/500/
Build finished. Tests FAILED. Build results available at: http://dsjenkins.cloudapp.net/jenkins/job/dSS_MR/500/
Well ... never say never. But that is result of my review - all instances are on stack.
And it is also my design target for this class. Long term ... I would like to move this sqlite3 wrapper to libds. Unfortunately I did not catch this locking when the class was introduced. I talked with @taw offline and he agreed to remove the locking.
Mentioned in commit e7de2e33
Please register or sign in to reply