Merged by
(May 3, 2025 1:05am UTC)
Activity
@pkochanowski you asked for -Wsign-compare in ds/random-test.cpp
I still have the following in my setup on Ubuntu:
../src/ds/str-test.cpp: In function ‘std::ostream& {anonymous}::operator<<(std::ostream&, {anonymous}::Enum)’: ../src/ds/str-test.cpp:31:3: warning: control reaches end of non-void function [-Wreturn-type] } ^And it makes me wonder why Jenkins do not display this warnings? I have gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609 and I did not add any -W options manually. @jeanvisagie do you know why I could have different warnings than Jenkins?
Build finished. Tests FAILED. Build results available at: http://dsjenkins.cloudapp.net/jenkins/job/dSA_MR/193/
Build finished. Tests FAILED. Build results available at: http://dsjenkins.cloudapp.net/jenkins/job/dSA_MR/194/
Build finished. Tests FAILED. Build results available at: http://dsjenkins.cloudapp.net/jenkins/job/dSA_MR/195/
Build finished. Tests FAILED. Build results available at: http://dsjenkins.cloudapp.net/jenkins/job/dSA_MR/196/
added 1 commit
- 12e57bcc - configure.ac: tune warnings, add -Werror for debug build
Build finished. Tests FAILED. Build results available at: http://dsjenkins.cloudapp.net/jenkins/job/dSS_MR/762/
added 1 commit
- 4d6b701a - configure.ac: tune warnings, add -Werror for debug build
Build finished. Tests FAILED. Build results available at: http://dsjenkins.cloudapp.net/jenkins/job/dSS_MR/763/
Build finished. Tests FAILED. Build results available at: http://dsjenkins.cloudapp.net/jenkins/job/dSS_MR/764/
-
added more cleanups. ready for review & merge
I gave up -Werror. We would need to white list specific compilers. And google answer for question "autoconf detect compiler version" was too convoluted for me to follow. Maybe next time.
But my local build with clang compiles with "-Wall -Wextra -Werror -Wno-ignored-qualifiers -Wno-unused-parameter"
26 26 27 CXXFLAGS="$CXXFLAGS -std=gnu++0x" 27 DSS_CPPFLAGS="" 28 DSS_CPPFLAGS+=" -Werror=return-type -Werror=int-to-pointer-cast" 29 DSS_CPPFLAGS+=" -Wno-unused-parameter" 30 31 DSS_CXXFLAGS="-std=gnu++0x" 32 33 CFLAGS="$DSS_CPPFLAGS $CFLAGS" 34 CXXFLAGS="$DSS_CPPFLAGS $DSS_CXXFLAGS $CXXFLAGS" 28 35 MT_OPTION([debug], [enable], 29 36 [enable debug flags during compilation], 30 37 [ 31 CFLAGS="$CFLAGS -D_DEBUG -g -Wall -O1" 32 CXXFLAGS="$CXXFLAGS -D_DEBUG -g -Wall -O1" 38 CFLAGS="-D_DEBUG -g -Wall -O1 $CFLAGS" 24 24 export PATH=$PATH:$MT_SEARCHPATH_PROGS 25 25 fi 26 26 27 CXXFLAGS="$CXXFLAGS -std=gnu++0x" 27 DSS_CPPFLAGS="" -
- CFLAGS are C only
- CXXFLAGS are C++ only
- CPPFLAGS are for both
At least it works this way with AM_ prefix.
Edited by Branislav Katreniak
mentioned in commit a056f6d0
