Renamed dsDevices to dsdevices for consistency with requirements

@mtross What is correct form? dsdevice or dsDevice?

The main question is whether you consider it one word or two words.

• I see it as dsDevice in https://git.digitalstrom.org/digitalstrom-documentation/public-api-documentation/blob/master/service/apartment/apartment_model.apib.
• I see it as dsdevice member and dSDevice type in https://git.digitalstrom.org/digitalstrom-documentation/digitalstrom-documentation/raw/master/datamodel/apartment_structure.md

I suggest to use dsDevice for member and DsDevice for type.

I suggest to avoid dS in model and in api ... to use it only for branding purposes.

The "dS" prefix is commonly used in documentation, it is not only branding. The model contains class name dSDevice and member name dsdevice, in API document apartment_model.apib you already requested to change member name to dsDevice to comply to camel-case convention. The class name can be dSDevice or DSDevice (like today in dss).

Do we agree these conventions in model?

• class names starts with upper case ... CamelCase?
• members starts start with lower case ... camelCase?

I would like to come with rule for for abbreviations (DS in this case):

• like normal word? I.e. dsDevice, DsDevice
• all letters follow the case of the first letter? I.e. dsDevice, DSDevice
• ???

I clarified with @mtross.

The right form is dsDevices. The identifier is composed of 2 words and uses camelCase. We will fix the model documentation.

The rule for abbreviations in identifiers proposed by mtross that shall go into style guides is:

• all letters follow the case of the first letter? I.e. dsDevice, DSDevice

This rule shall be introduced into public api guidelines. Then it will be adopted by dss guidelines.

Long story short: the code is right. The documentation needs to be fixed.

closed

Fix in documentation: https://git.digitalstrom.org/digitalstrom-documentation/digitalstrom-documentation/merge_requests/114

mentioned in merge request !1282 (merged)